feat: MySQL/MariaDB adapter - #34
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- supportedWarehouses now includes mysql; main_test rejection case uses snowflake - CompilationSql resolveTarget emits `schema`.`name` for mysql (no catalog level) - indexAssertion backtick-quotes columns; sqlString uses backslash escaping for mysql - unit tests for resolveTarget/sqlString/indexAssertion mysql branches Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Table CTAS, CREATE OR REPLACE VIEW, incremental (CTAS + unique index then ON DUPLICATE KEY UPDATE upsert), assertion via view + row count. Materialized views error out (deferred). Wired into the ExecutionSql dispatcher. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mysql2-backed pool with withClientLock + single release path, verifyConnection fail-fast, and a convertFieldType mapping MySQL DATA_TYPEs to field primitives. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
create() with fail-fast verify + optional TLS, withClientLock delegating to the pool executor, EXPLAIN-based evaluate, information_schema introspection (tables/table/search/schemas), CREATE DATABASE IF NOT EXISTS, deleteTable. setMetadata is a deferred no-op for the MVP. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- credentials.read() validates MysqlConnection (host required) - init scaffolds a mysql .df-credentials.json template - warehouseOption accepts mysql; run/test commands create MySqlDbAdapter Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
MysqlFixture (2-arg ctor, env-bypass for the docker-bazel path; same class serves MySQL 3306 and MariaDB 3307) + run-mysql-db.sh launcher + BUILD. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Full-project run (table/view/incremental/merge/assertions), incremental append + upsert idempotency, EXPLAIN-based evaluate, fail-fast bad creds — verified PASSED on both mysql:8 (3306) and mariadb:11 (3307). Adds MYSQL_* env forwarding to scripts/docker-bazel; upsertInto only emits ON DUPLICATE KEY UPDATE when a uniqueKey exists (plain append otherwise). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Adds mysql2 to the cli package.json deps and mysql2/promise to the rollup externals (rollup matches the import specifier exactly), so the adapter's mysql2/promise import is not bundled. Fixes the cli bundle build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…nt comments - convertFieldType maps BIT->INTEGER, JSON/TIME->STRING; documents binary/blob/ geometry falling through to UNKNOWN (introspection-only metadata) - comment the upsertInto no-metadata fallback invariant and the byteLimit/ client-side rowLimit divergence from the streaming Postgres path Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a single
mysqlwarehouse adapter perplanning/specs/2026-06-17-mysql-mariadb-adapter-design.md. One adapter generates portable MySQL-dialect SQL that runs against both MySQL and MariaDB — engine-specific features ride throughoperations, mirroring how the BigQuery/Postgres adapters lean on the engine for the heavy lifting.What's included
MysqlConnectionadded to theWarehouseConfigunion (protos/configs.proto).mysqlaccepted insupportedWarehouses; MySQL backtick quoting inCompilationSql(two-part`schema`.`name`, backtick-quoted assertion columns, backslash string escaping).MysqlExecutionSql— table CTAS,CREATE OR REPLACE VIEW, incremental (fresh CTAS + unique index, thenON DUPLICATE KEY UPDATEupsert), assertion-as-view + row count. Materialized views error out (deferred).MySqlPoolExecutor—mysql2/promisepool, fail-fastverifyConnection, single release path (the Postgres: any failing statement double-releases the pg client ("Release called on client which has already been released") #32 release-once discipline baked in).MySqlDbAdapter—IDbAdapterviainformation_schemaintrospection,EXPLAIN-basedevaluate,CREATE DATABASE IF NOT EXISTS.initscaffolds a mysql.df-credentials.json,--warehouse mysqlaccepted, adapter wired intorun/test.mysql:8(3306) andmariadb:11(3307) (full project run, incremental append + upsert idempotency, assertion pass/fail,EXPLAINevaluate, fail-fast bad creds). Fixtures +tools/mysql/run-mysql-db.sh.Verification
./scripts/docker-bazel test //core/... //cli/...— all pass except the pre-existing, credentials-gated//cli:index_run_e2e_test(fails identically onmain; unrelated to this change).init --warehouse mysqlscaffolds correctly. (Full CLI compile/run end-to-end needs the 1.5.0 core on npm — the standalonecompileinstalls@sqlanvil/core@<version>; the in-repo build is fully verified via the integration suite, which uses the local core tarball.)Deferred (follow-up PRs)
Materialized views (error only), a
mysql: {}options block (engine/indexes/partitioning),description/columns→COMMENTmetadata, andintrospectfor MySQL sources.Version bump to 1.5.0 + publish is a separate release step after merge.
🤖 Generated with Claude Code